Discussion:
[SCM] GNU Autoconf source repository branch, master, updated. v2.69-18-g5fdd360
Eric Blake
2012-08-16 03:58:08 UTC
Permalink
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Autoconf source repository".

http://git.sv.gnu.org/gitweb/?p=autoconf.git;a=commitdiff;h=5fdd360bcbeeff0fdb3214aad1866c2f9eace98d

The branch, master has been updated
via 5fdd360bcbeeff0fdb3214aad1866c2f9eace98d (commit)
from b406df6adc6af9010f13d0c0fb43fa8ced8a5436 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5fdd360bcbeeff0fdb3214aad1866c2f9eace98d
Author: Nick Bowler <***@draconx.ca>
Date: Wed Aug 15 21:54:53 2012 -0600

AC_SUBST: don't underquote the variable name

Consider the following:

% cat >configure.ac <<'EOF'
AC_INIT([test], [0])

m4_define([FOO], [baz])
AC_SUBST([FOO], [bar])

AC_CONFIG_FILES([test])
AC_OUTPUT
EOF

% cat >test.in <<'EOF'
@FOO@
EOF

This produces no error messages at autoconf time and none at configure
time. Nevertheless, the substituted value of FOO is the empty string,
instead of bar, as expected. Sure enough, in the output variables
section of config.log, we see FOO='' instead of FOO='bar'. Looking
at the generated configure script, we see that AC_SUBST has produced
baz=bar in the output, instead of the expected FOO=bar. But this is
the only place: everywhere else is still using FOO.

* lib/autoconf/general.m4 (AC_SUBST): Add another layer of
quoting.
* THANKS: Update.

Signed-off-by: Eric Blake <***@redhat.com>

-----------------------------------------------------------------------

Summary of changes:
THANKS | 2 +-
lib/autoconf/general.m4 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/THANKS b/THANKS
index d90237d..be83c28 100644
--- a/THANKS
+++ b/THANKS
@@ -302,7 +302,7 @@ Nathanael Nerode ***@gcc.gnu.org
Nelson H. F. Beebe ***@math.utah.edu
Nicolas Joly ***@pasteur.fr
Nicolás Lichtmaier ***@synapsis-sa.com.ar
-Nick Bowler ***@elliptictech.com
+Nick Bowler ***@draconx.ca
NightStrike ***@gmail.com
Nishio Futoshi ***@d3.dion.ne.jp
Noah Elliott ***@hera.llnl.gov
diff --git a/lib/autoconf/general.m4 b/lib/autoconf/general.m4
index d06fdf5..51cee30 100644
--- a/lib/autoconf/general.m4
+++ b/lib/autoconf/general.m4
@@ -2180,7 +2180,7 @@ m4_define([AC_SUBST],
[m4_fatal([$0: `$1' is not a valid shell variable name])])]dnl
[AC_SUBST_TRACE([$1])]dnl
[m4_pattern_allow([^$1$])]dnl
-[m4_ifvaln([$2], [$1=$2])[]]dnl
+[m4_ifvaln([$2], [[$1]=$2])[]]dnl
[m4_set_add([_AC_SUBST_VARS], [$1])])# AC_SUBST




hooks/post-receive
--
GNU Autoconf source repository
Loading...